Rate my Diamond Pokemon Team?

Electvire - Pretty darn good, if I do say so myself. Your many physical attacks make good use of Electvire's massive attack and that adamant nature doesn't hurt either. The one thing I'd have to suggest is to eliminate Thunder Wave and replace it with Ice Punch if you can. This allows for better type coverage (13 out of 17, wooo!)

Scizor - I'm assuming that your Scizor is NOT a standard Baton Passer, though if you want that strategy, just ask. Assuming as I am that he's playing the role of a sweeper, I suggest the following moveset:

~Agility

~Metal Claw/Iron Head (Depending on Ability!)

~X-Scissor

~Brick Break

Metal Claw/Iron Head can be decided on wether or not your Scizor has Technician or Swarm. If it has Technician, choose Metal Claw, as it's power will be boosted. If your Scizor has Swarm, however, choose X-Scissor. After the speed boost you'll have time to squeeze in a couple of powered-up X-Scissors before getting knocked out. Break Break is Scizor's standard defense against assorted steel types that may take him out. Same with Infernape XP.

Flygon - Dragon claw is fine, possibly replace with Stone Edge if you want residual damage, though I don't reccomend it. EQ is standard, so fine. Roost is good, too. Maybe you'll have a per-WAIT A MINUTE. AERIAL ACE? HOW DARE YOU! Hahaha, just kidding. Switch Aerial Ace with something to take out Skarm/Salamence, that kinda thing. Your choice, though Fire Blast is reccomended.

Aggron - w00t for Under-used. Anyway, I have no idea what your planning to do with this thing. SOOOO, I'm suggesting a SubPunch set. Switch Iron Head with Substitute and Brick Break with Focus Punch. Or leave it like it is. Up to you, I've no experience with Aggron =/.

Typhlosion - I love you XP. It's sad, no one seems to realize how good Typhlosion really is! One of my favorites...Moving on, switch Flamethrower with EQ. And POSSIBLY Focus BLAST with Focus PUNCH. Just suggestions, though either one is fine. <3 it.

Drapion - Ewwww. Drapion is a meany. I hated fighting it at E4. Anyway, I'm gonna assume that this is another sweeper. Keep Swords Dance and EQ, switch Crunch and Poison Jab with Night Slash and Fire Fang. Better than Knock Off due to more overall damage.

Overall - 7.5/10. Your team is good, and quite powerful by the looks of it, but I personally feel that you need more roles. Having a team full of (What I assume to be sweepers) is nice, but your going to need more roles.

Everyone else has provided good answers for your pokemon but I have a suggestion for Gallade. Firstly Gallade usually is a better attacker so you should only use physical moves. The best moves would be- Psycho Cut, Close Combat, Stone Edge, Night Slash. Psycho Cut is physical so it's better for Gallade than Psychic. Close Combat is more powerful than Brick Break. Gallade has only two weaknesses, flying and ghost, so Stone Edge and Night Slash will take care of that and they are pretty good moves. (Originally it was suggested that Gallade have a grass move and if you want one you should teach it leaf blade with a heart scale)

I see you've taken a liking into EV training. Kudos to you. :) I'm gonna have to give you a 9 out of 10. Overall great strategizing on your part. You better get going though! Training that team is gonna take awhile, especially if you're looking to raise them to Lvl100. Good luck!

Here's my team btw:

http://i5.photobucket.com/albums/y158/madeinlies/7...

it is very good 9/10 but you can make it better by adding a ghost or physic Pokemon like gallade or dusknoir