whats wrong with this php code?

Try this: Make sure the mysql_connect is proper

$connect = mysql_connect('host','username','password');

<?php

$username = $_POST['username'];

$password = $_POST['password'];

if ($username&&$password)

{

$connect = mysql_connect('host','username','password');

if(!$connect)

die("could not connect to database");

mysql_select_db("a4264749_login") or die ("couldn't find database");

$query = mysql_query("SELECT * FROM users WHERE username='$username'");

$numrows = mysql_num_rows ($query);

if ($numrows!=0){

}

else {

die ("That user does not exist");

}

}

else

{

die ("Please enter a username and password");

}

?>

It would help to know how it failed. If it was script error then give us the error message and we can really help you out. I'm guessing that your code just doesn't do what you want it to but runs?

If this is the case try these solutions:

1) In your SQL place ` yes ` not " or ' around your table names like this.

$query = mysql_query("SELECT * FROM `users` WHERE `username` = '$username';");

Note: I added a semi-colon in that code as well, that's just habit for me.

2) This code is wrong, you started it with the brackets facing the wrong way:

if ($numrows!=0)

}

{

Should be this:

if ($numrows!=0)

{

}

Put it on one line like so to easily see this: if ($numrows!=0) { <-open then close->}

Keep up the good work though. You might want to check out some free PHP tutorials here: http://www.phpacademy.org/

it might be curly brackets problem in your code. they need to be placed correctly. On more tips, be careful with SQL injection with your code

good luck