Shanghai vs Dubai, which city is better in terms of offering tourist attractions?

Dubai has more specific attractions for tourists. Shanghai is mostly a business city that doesn't have much aimed at tourists.

But other cities in the Middle East or China are much more interesting than either of those, like Istanbul, Cairo, Marrakesh, or Beijing. Shanghai and Dubai are mostly very new cities, while those others have historic sites going back hundreds or thousands of years.