nothing you say to your lawyer can ever be revealed to anyone even after why is vance breaking this law with cohen?

Your statement is simply not true.  Could you share your research?  Confidentiality can be violated for several reasons, and that depends on the State.  Anyway, your statement is untrue.  I am baffled by the FACT that you can research a topic but not understand your own research.

False, there are exceptions. Not only for lawyers, but priests and physicians too including psychologist. in fact, there is a legal obligation to report certain events. Also, in criminal cases certain confidentiality may well be revealed as necessary; where there is an obligation for a lawyer to tell the truth. Including in defense of false charges/allegations. Lawyers do not lose their rights to defend themselves just because they defended a crook in the past. If it is a gray area, at worse you could lose your license.  

Really? Nothing?

So, if you tell your lawyer that you are going to commit a crime, they are not allowed to revel this? 

Go ahead and try it....

Lawyers are also not allowed to break the law.  Cohen did.   That makes him a co-conspirator (if he was following instructions) not a lawyer.

A judge can also order a lawyer to break attorney/client privilege under certain conditions.

Unless in furtherance of a crime!

Lawyers are officers of the Court! As such they're supposed to avoid taking part in crimes!