What is the better place to get a golf lesson?

It depends on how good the pro is at each locations. If the course is just a cheap public course, the pro probably isn't the best. If it is a country club or reputable public course those would be better places to get lessons. By taking them at a course you have the oportunity to use the driving range or putting green. At at golf store you can only hit into a net or a simulator.

Which pro is known for giving the better lessons? Is it the pro at Golfsmith or the pro at the local course?. Is the person at Golfsmith a golf professional or a store clerk?

The more money it costs, the better the lessons. Try to get someone teaching you who has the most experience possible. I got lessons from someone really good, and within an hour i could hit really good shots after almost no experience. Also try to get private lessons, not public lessons. In private you learn more, and you get more time. You can always turn to the internet too. I'm sure youtube has some pretty good golf tutorials.

The easiest way to learn golf like a pro is by following "The Simple Golf Swing" program. It's primarily a 31 page eBook that teaches golfers how to make solid contact with the ball, how to avoid hitting fat, how to avoid slicing, how get more power, accuracy, and consistency in your swing. Consistency being the number 1 golf skill.

You not only get the eBook though, you also receive a ton of extra material including video, lessons on putting, driving, chipping, sand play etc. Here is their official site: http://www.golfswingguru.net/