Problems with variables after upgrading to PHP 5.6?

This is the first time I ever saw anyone use extract($_GET); I think one reason is that it becomes unclear where those variables come from. $_GET['cur_time'], makes it clear that cur_time is from $_GET, and if it doesn't exist, trace the error to source of problem. Overwriting existing variable problem, if you already have a $cur_time variable in that scope, it will be populated with what's in GET, making the problem difficult harder to find.

Your problem is here, sorry caps :)

else {

$cur_time = strtotime($cur_time); // THIS BECOMES REDUNDANT

$cur_time = date("Y-m-d'); // BECAUSE THIS OVERWRITES THAT

}

----

// See Example#2 here on how to check time --> http://php.net/manual/en/function.strtotime.php

// This is quite dense, but it should replace what you have there.

// $current_date would be what you reference later to use

if (empty($_GET['cur_time']) || ($current_date = strtotime($_GET['cur_time'])) === false) {

$current_date = date('Y-m-d');

}

----

Walk through:

The || or condition first checks left hand side if it is true, if it is, we are good to go, right side won't be processed, code will jump into the if block.

If $_GET['cur_time'] is empty, we proceed to populate $current_date with today's date.

If $_GET['cur_time'] is not empty, script proceeds to right hand side of the || conditional check. Here, we check if $_GET['cur_time'] is valid time by using strtotime() and assigning the result to a variable $current_date, if $current_date is false, it means strtotime cannot parse that string, and we proceed to populate $current_date with today's date.

So if $current_date is not false, it will hold a correctly formatted date that can be used later in your script.

Replace

if (!$cur_time) {

with

if (!isset($cur_time)) {

There's also a mismatched quote in the second date() String.

Also, in the else clause the first line is redundant.